Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add include_podiatrist_services() #155

Draft
wants to merge 6 commits into
base: feat/include-gld-purchases
Choose a base branch
from

Conversation

signekb
Copy link
Contributor

@signekb signekb commented Sep 20, 2024

Note: This PR is a work in progress. I will split it up into smaller/atomic PRs when we return to this project

Description

This PR adds include_podiatrist_services().

For this, I have:

  1. Added the logic to algorithm.csv
  2. Regenerated the package data with the targets pipeline (i.e., you don't have to look at the files in _targets/ and data/)
  3. Updated the regex logic in get_algorithm() to include regex logic that's in a parenthesis
  4. Added tests for get_algorithm (I'm not sure we need this, but I made it to test the updated regex, so I thought why not)
  5. Added a helper function to transform the honuge wwyy format to a hmd date with tests
  6. Added the inclusion function include_podiatrist_services() with tests

Notes: This PR is stacked on #138 to avoid merge conflicts in algorithm.csv

@signekb
Copy link
Contributor Author

signekb commented Sep 20, 2024

@lwjohnst86 Since this is a stacked PR, it doesn't require reviews to be merged. Should we add a protection rule for stacked PRs like we have for PRs to main?

@signekb signekb marked this pull request as draft September 25, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant